Skip to content

[ES|QL] Add new queries into nyc_taxis track to measure DateTrunc to RoundTo transformation#824

Merged
fang-xing-esql merged 3 commits intoelastic:masterfrom
fang-xing-esql:datetrunc-to-roundto
Jul 24, 2025
Merged

[ES|QL] Add new queries into nyc_taxis track to measure DateTrunc to RoundTo transformation#824
fang-xing-esql merged 3 commits intoelastic:masterfrom
fang-xing-esql:datetrunc-to-roundto

Conversation

@fang-xing-esql
Copy link
Copy Markdown
Member

@fang-xing-esql fang-xing-esql commented Jul 22, 2025

Add 3 new date_histogram queries with different calendar intervals to nyc_taxis track to measure performance improvements related to filter-by-filter aggregation in ES|QL, it is related to elastic/elasticsearch#131341 and elastic/elasticsearch#128639

@fang-xing-esql fang-xing-esql added the new workload Any work related to adding a new track or functionality within a track label Jul 22, 2025
@fang-xing-esql fang-xing-esql mentioned this pull request Jul 22, 2025
Closed
nik9000
nik9000 approved these changes Jul 23, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They'd be useful for me if we have the space for them.

inqueue
inqueue approved these changes Jul 24, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@inqueue inqueue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fang-xing-esql
Copy link
Copy Markdown
Member Author

fang-xing-esql commented Jul 24, 2025

Thanks for reviewing @nik9000 @inqueue !

@fang-xing-esql fang-xing-esql merged commit 1658376 into elastic:master Jul 24, 2025
14 checks passed
@NickDris NickDris mentioned this pull request Aug 28, 2025
Closed
@esbenchmachine esbenchmachine added the backport pending Awaiting backport to stable release branch label Dec 19, 2025
@esbenchmachine
Copy link
Copy Markdown
Collaborator

esbenchmachine commented Dec 19, 2025

💔 All backports failed

Status Branch Result
❌ 9.2 Backport failed because of merge conflicts
❌ 9.3 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

backport --pr 824

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@esbenchmachine
Copy link
Copy Markdown
Collaborator

esbenchmachine commented Dec 19, 2025

💔 All backports failed

Status Branch Result
❌ 9.2 Backport failed because of merge conflicts
❌ 9.3 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

backport --pr 824

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@fang-xing-esql fang-xing-esql deleted the datetrunc-to-roundto branch April 6, 2026 20:34
@esbenchmachine
Copy link
Copy Markdown
Collaborator

esbenchmachine commented Apr 7, 2026

@fang-xing-esql
A backport is pending for this PR.
Apply all the labels that correspond to Elasticsearch minor versions expected to work with this PR, but select only from the available ones.
If intended for future releases, apply label for next minor

When a vX.Y label is added, a new pull request will be automatically created, unless merge conflicts are detected or if the label supplied points to the next Elasticsearch minor version. If successful, a link to the newly opened backport PR will be provided in a comment.

In case of merge conflicts during backporting, create the backport PR manually following the steps from README:
Final steps to complete the backporting process:

  1. Ensure the correct version labels exist in this PR.
  2. Ensure each backport pull request is labeled with backport.
  3. Review and merge each backport pull request into the appropriate version branch.
  4. Remove backport pending label from this PR once all backport PRs are merged.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nik9000 nik9000 nik9000 approved these changes

@inqueue inqueue inqueue approved these changes

Assignees

No one assigned

Labels

backport pending Awaiting backport to stable release branch new workload Any work related to adding a new track or functionality within a track v9.2 v9.3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fang-xing-esql @esbenchmachine @nik9000 @inqueue