Support synthetic source in tsdb and nyc_taxis tracks#268
Merged
nik9000 merged 4 commits intoelastic:masterfrom May 16, 2022
Merged
Support synthetic source in tsdb and nyc_taxis tracks#268nik9000 merged 4 commits intoelastic:masterfrom
nik9000 merged 4 commits intoelastic:masterfrom
Conversation
This was referenced May 9, 2022
tsdb/README.md
Outdated
| * `index_mode` (default: time_series): Whether to make a standard index (`standard`) or time series index (`time_series`) | ||
| * `codec` (default: default): The codec to use compressing the index. `default` uses more space and less cpu. `best_compression` uses less space and more cpu. | ||
| * `ingest_order` (default: jumbled): Should the data be loaded in `sorted` order or a more `jumbled`, mostly random order. | ||
| * `synthetic_source` (default: false): Should we enable `synethetic` _source to save space?. |
Contributor
There was a problem hiding this comment.
Nit: synethetic has a typo
michaelbaamonde
approved these changes
May 12, 2022
Contributor
michaelbaamonde
left a comment
There was a problem hiding this comment.
Did you intentionally add this to the nyc_taxis track, too? If so, could you document the synthetic_source track parameter there, too? The only other thing is the typo in the tsdb README.
Otherwise, this works for me locally. I wish there were an obvious way around the repetition in the jinja templates, but I don't have any brilliant ideas on that front.
Thanks for putting this together!
Member
Author
Huh! I did intentionally do it. Then forgot.... Sorry about that. It is useful to have it there too. I'll update the docs. |
Member
Author
|
Thanks @michaelbaamonde ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for synthetic source to the tsdb and nyc_taxis tracks.