Revert "Add support for an optional value in discovery fields"#923
Merged
mrodm merged 2 commits intoelastic:mainfrom Jul 9, 2025
Merged
Revert "Add support for an optional value in discovery fields"#923mrodm merged 2 commits intoelastic:mainfrom
mrodm merged 2 commits intoelastic:mainfrom
Conversation
mrodm
commented
Jul 8, 2025
| discovery: | ||
| fields: | ||
| - name: 12345 | ||
| - {} |
Contributor
Author
There was a problem hiding this comment.
Ensure empty object is not a valid option.
2 tasks
kpollich
approved these changes
Jul 8, 2025
💚 Build Succeeded
History
cc @mrodm |
jsoriano
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Revert the addition of the optional
valuefield underdiscovery.fieldsin favor ofdiscovery.datasets#919Related issues