Teach pipeline validator about terminate processor#847
Closed
efd6 wants to merge 2 commits intoelastic:mainfrom
Closed
Teach pipeline validator about terminate processor#847efd6 wants to merge 2 commits intoelastic:mainfrom
efd6 wants to merge 2 commits intoelastic:mainfrom
Conversation
a493f90 to
bb47636
Compare
jsoriano
previously approved these changes
Dec 17, 2024
Comment on lines
+13
to
+15
| - description: Add `terminate` processor to list pipeline spec. | ||
| type: enhancement | ||
| link: https://github.com/elastic/package-spec/pull/847 |
Member
There was a problem hiding this comment.
I think this could be added in a 3.3.2. Both spec 3.3 and the terminate processor were introduced in 8.16,
Suggested change
| - description: Add `terminate` processor to list pipeline spec. | |
| type: enhancement | |
| link: https://github.com/elastic/package-spec/pull/847 | |
| - version: 3.3.2-next | |
| changes: | |
| - description: Add `terminate` processor to list pipeline spec. | |
| type: enhancement | |
| link: https://github.com/elastic/package-spec/pull/847 |
jsoriano
reviewed
Dec 17, 2024
| # set_security_user: false # Applicable to packages? | ||
| sort: { type: object } | ||
| split: { type: object } | ||
| terminate: { type: object } |
Member
There was a problem hiding this comment.
Btw, please add a patch below, so this processor is actually not available in older versions of the spec, something like this:
- before: 3.3.0
patch:
- op: remove
path: /definitions/processors/terminate # remove terminate processor validation
03f60e1 to
d304004
Compare
💔 Build Failed
Failed CI Steps
History
cc @efd6 |
Contributor
Author
|
@jsoriano It seems that that does not work, unless I have misunderstood your instructions. |
mrodm
reviewed
Dec 18, 2024
Comment on lines
+119
to
+122
| - before: 3.3.0 | ||
| patch: | ||
| - op: remove | ||
| path: /definitions/processors/terminate # remove terminate processor validation |
Contributor
There was a problem hiding this comment.
This array item should be added as the first one (as it references a newer version in the before field).
And looking at the error:
failed to load schema for "integration/elasticsearch/pipeline.spec.yml": failed to apply patch: error in remove for path: '/definitions/processors/terminate': unable to remove nonexistent key: terminate: missing value
the path should be updated too.
I think it should be like this:
versions:
- before: 3.3.0
patch:
- op: remove
path: /definitions/processor/properties/terminate # remove terminate processor validation
- before: 3.1.0
patch:
- op: remove
path: /definitions/processors/if # remove rename processor validation
- op: remove
path: /definitions/processors/then # remove rename processor validation
2 tasks
Member
|
Continuing with this change in #857. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add terminate processor to list of valid processors.
Why is it important?
Currently the processor cannot be used.
Checklist
test/packagesthat prove my change is effective.spec/changelog.yml.Related issues