Assign error code to path_match in manifests#654
Closed
jsoriano wants to merge 1 commit intoelastic:mainfrom
Closed
Assign error code to path_match in manifests#654jsoriano wants to merge 1 commit intoelastic:mainfrom
jsoriano wants to merge 1 commit intoelastic:mainfrom
Conversation
💚 Build Succeeded
cc @jsoriano |
Merged
mrodm
approved these changes
Oct 25, 2023
Member
Author
|
Not needed by now, closing. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Assign new error code
JSE00001to validation errors raised when data streams define dynamic mappingswith path_match in data stream manifests.
Why is it important?
Since Package Spec v3, it is mandatory to use field files to define fields that can be defined there. This
is the case of dynamic fields with
path_match.We have found that packages using these mappings and
dynamic: "runtime"cannot ingest documentswith the error
Missing intermediate object labels, likely caused because the parent object doesn't existin the mapping.
We should probably make Fleet to create these intermediate objects.
In the meantime,
JSE00001may offer a escape hatch for packages needing this, like in the test packageadded in this PR.
After this change, packages with this issue, can add a
validation.ymlfile at the root of the package withthe following content to ignore this error:
Checklist
test/packagesthat prove my change is effective.spec/changelog.yml.Related issues