Allow to set 'index: false' in dynamic templates defined in data streams#650
Merged
jsoriano merged 1 commit intoelastic:mainfrom Oct 24, 2023
Merged
Conversation
💚 Build Succeeded
cc @jsoriano |
mrodm
approved these changes
Oct 24, 2023
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allow to set
index: falsein dynamic templates defined in data streams.Why is it important?
Package Spec v3 introduced validation for fields defined in manifests in data streams.
indexwas not added then, but this is used by the APM package.In the case of the field in APM, it cannot be migrated to fields definitions because the definition is not based on the name of the field.
Checklist
test/packagesthat prove my change is effective.spec/changelog.yml.Related issues