Allow metric_type without type for external fields#637
Merged
jsoriano merged 3 commits intoelastic:mainfrom Oct 5, 2023
Merged
Allow metric_type without type for external fields#637jsoriano merged 3 commits intoelastic:mainfrom
jsoriano merged 3 commits intoelastic:mainfrom
Conversation
mrodm
previously approved these changes
Oct 5, 2023
Contributor
mrodm
left a comment
There was a problem hiding this comment.
👍
Not related to this PR , but probably these comments about the patches are interchanged ?
Should this comment
removing requirement of object_type and minimum fields when type is object
be related to this item /items/allOf/7
Member
Author
Right, I probably messed this up when adding this change. Thanks! |
💚 Build Succeeded
History
cc @jsoriano |
mrodm
approved these changes
Oct 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allow the use of metric_type without defining a type.
Why is it important?
To be able to define TSDB related settings for external fields.
Checklist
test/packagesthat prove my change is effective.spec/changelog.yml.Related issues