Add search to the elements in dahsboards that can be used by value#635
Add search to the elements in dahsboards that can be used by value#635jsoriano merged 1 commit intoelastic:mainfrom
Conversation
💚 Build Succeeded
cc @jsoriano |
kertal
left a comment
There was a problem hiding this comment.
LGTM, looking at the code change, just a question how it could be tested, since this is new topic to me
| var references []reference | ||
| for _, reference := range allReferences { | ||
| switch reference.Type { | ||
| case "lens", "visualization", "map": |
There was a problem hiding this comment.
LGTM, just out of curiosity , no being where this warning is triggered, how can this be tested? thx
There was a problem hiding this comment.
You can run the following command to test from a package directory:
elastic-package check
You can find packages to test in https://github.com/elastic/integrations/
These errors will be displayed only as warnings, unless you set the environment variable PACKAGE_SPEC_WARNINGS_AS_ERRORS=true.
There was a problem hiding this comment.
Just as a note, this is going to be applied independently of the spec version used in the packages.
There was a problem hiding this comment.
Just as a note, this is going to be applied independently of the spec version used in the packages.
I think this is fine, as it will only produce validation errors in v3.
Fix #633