Merged
Conversation
Contributor
Author
…egacy-visualization-validation
jsoriano
reviewed
Sep 27, 2023
Member
jsoriano
left a comment
There was a problem hiding this comment.
Looks great, thanks! Added a couple of comments about safer type conversions and checking all visualizations and dashboards even if one fails.
code/go/internal/validator/semantic/validate_kibana_no_legacy_visualizations.go
Show resolved
Hide resolved
code/go/internal/validator/semantic/validate_kibana_no_legacy_visualizations.go
Outdated
Show resolved
Hide resolved
code/go/internal/validator/semantic/validate_kibana_no_legacy_visualizations.go
Outdated
Show resolved
Hide resolved
drewdaemon
commented
Sep 27, 2023
code/go/internal/validator/semantic/validate_kibana_no_legacy_visualizations.go
Outdated
Show resolved
Hide resolved
jsoriano
previously approved these changes
Sep 27, 2023
code/go/internal/validator/semantic/validate_kibana_no_legacy_visualizations.go
Outdated
Show resolved
Hide resolved
code/go/internal/validator/semantic/validate_kibana_no_legacy_visualizations.go
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
|
Contributor
Author
|
@elastic/ecosystem as far as I'm concerned, this PR is ready to be merged. Feel free to do so if you approve. Thanks! |
drewdaemon
commented
Sep 28, 2023
| {fn: semantic.ValidateRoutingRulesAndDataset, types: []string{"integration"}, since: semver.MustParse("2.9.0")}, | ||
| {fn: semantic.ValidateKibanaNoDanglingObjectIDs, since: semver.MustParse("3.0.0")}, | ||
| {fn: semantic.ValidateKibanaFilterPresent, since: semver.MustParse("3.0.0")}, | ||
| {fn: semantic.ValidateKibanaNoLegacyVisualizations, types: []string{"integration"}, since: semver.MustParse("3.0.0")}, |
Contributor
Author
There was a problem hiding this comment.
Should this rule be limited to type "integration"?
Contributor
There was a problem hiding this comment.
That should we ok, since input packages are not allowed to have kibana assets, just integration packages.
https://github.com/elastic/package-spec/blob/49120aea627a1652823a7f344ba3d1c9b029fd5a/spec/input/spec.yml
2 tasks
This was referenced Sep 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fails when any legacy Kibana visualizations are detected in a package.
Why is it important?
We would like to migrate away from legacy visualizations to give our customers a better experience and decrease the maintenance burden of so many editors.
Checklist
test/packagesthat prove my change is effective.spec/changelog.yml.Related issues