Set owner.type field as required#604
Merged
jsoriano merged 4 commits intoelastic:mainfrom Sep 19, 2023
Merged
Conversation
- Setting the owner.type field as required. This is to prevent situations where a package is update to package-spec 2.11.0 or later and the package, which might be an Elastic-owned or vendor-maintained, is accidentally marked as community-owned instead (as that was the previous default). - Add test - Update other tests that are at version 3.0.0
💚 Build Succeeded
History
|
jsoriano
approved these changes
Sep 18, 2023
Member
jsoriano
left a comment
There was a problem hiding this comment.
LGTM. Could you please also open a PR to update elastic-package?
- The troubleshooting docs for breaking changes: https://github.com/elastic/elastic-package/blob/main/docs/howto/update_major_package_spec.md
- The template used by
elastic-package create package: https://github.com/elastic/elastic-package/blob/cafa676c6ec7420e08023f9af98185b114879714/internal/packages/archetype/_static/package-manifest.yml.tmpl#L75
Thanks!
Contributor
Author
PR is here: elastic/elastic-package#1460 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Why is it important?
This is to prevent situations where a package is updated to package-spec 2.11.0 or later and the package, which might be an Elastic-owned or vendor-maintained, is accidentally marked as community-owned instead (as that was the previous default).
Checklist
test/packagesthat prove my change is effective.spec/changelog.yml.Related issues