Merged
Conversation
jsoriano
previously approved these changes
Sep 12, 2023
Member
jsoriano
left a comment
There was a problem hiding this comment.
Looks good, added a couple of nitpicks.
| } | ||
|
|
||
| func loadItemSchema(fsys fs.FS, path string, contentType *spectypes.ContentType) ([]byte, error) { | ||
| func loadItemSchema(fsys fs.FS, path string, contentType *spectypes.ContentType, specVersion *semver.Version) ([]byte, error) { |
Member
There was a problem hiding this comment.
No need to pass by pointer here, right?
Suggested change
| func loadItemSchema(fsys fs.FS, path string, contentType *spectypes.ContentType, specVersion *semver.Version) ([]byte, error) { | |
| func loadItemSchema(fsys fs.FS, path string, contentType *spectypes.ContentType, specVersion semver.Version) ([]byte, error) { |
Contributor
Author
There was a problem hiding this comment.
True, it can be passed by value. I'll change it
| } | ||
| if contentType != nil && contentType.MediaType == "application/x-yaml" { | ||
| return convertYAMLToJSON(data) | ||
| return convertYAMLToJSON(data, specVersion.LessThan(semver.MustParse("3.0.0"))) |
Member
There was a problem hiding this comment.
Nit. Consider extracting the parsed version to a constant.
💚 Build Succeeded
History
cc @mrodm |
Member
|
Awesome! 🏆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR disallows to use fields with dots. For instance:
Those files should be updated to:
Why is it important?
Allowing dotted fields leads to ambiguous specifications.
Checklist
test/packagesthat prove my change is effective.spec/changelog.yml.Related issues