Add support for log files to deploy terraform spec#571
Merged
jsoriano merged 5 commits intoelastic:mainfrom Jul 26, 2023
Merged
Add support for log files to deploy terraform spec#571jsoriano merged 5 commits intoelastic:mainfrom
jsoriano merged 5 commits intoelastic:mainfrom
Conversation
387936d to
29f56cc
Compare
jsoriano
reviewed
Jul 26, 2023
Member
jsoriano
left a comment
There was a problem hiding this comment.
Wondering if logs is enough or if we should have a directory for arbitrary files that could be provisioned.
7418c53 to
1a88c9f
Compare
jsoriano
reviewed
Jul 26, 2023
Member
jsoriano
left a comment
There was a problem hiding this comment.
LGTM, only some comments about descriptions.
1a88c9f to
0896c52
Compare
jsoriano
reviewed
Jul 26, 2023
Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
Closed
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for
logfiles in deploy terraform spec.Why is it important?
We should be able to add
logfiles intfdirectory to add them into terraform resources for package testingChecklist
test/packagesthat prove my change is effective.spec/changelog.yml.