Add condition to define stack capability requirements#561
Merged
jsoriano merged 2 commits intoelastic:mainfrom Jul 5, 2023
Merged
Add condition to define stack capability requirements#561jsoriano merged 2 commits intoelastic:mainfrom
jsoriano merged 2 commits intoelastic:mainfrom
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
mrodm
previously approved these changes
Jul 5, 2023
Contributor
mrodm
left a comment
There was a problem hiding this comment.
LGTM
Just a suggestion to avoid duplicated values when defining this new field in a manifest.
Co-authored-by: Mario Rodriguez Molins <marrodmo@gmail.com>
💚 Build Succeeded
Historycc @jsoriano |
mrodm
approved these changes
Jul 5, 2023
andrewkroh
reviewed
Sep 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add condition to define stack capability requirements.
Why is it important?
There are some features that may be disabled on some deployments, and there are packages that need these features. We need something to indicate the required features so we can prevent users to try to use these packages on deployments where they are not going to work properly.
Checklist
test/packagesthat prove my change is effective.spec/changelog.yml.Related issues