Skip to content

Add threat_intel package category#366

Merged
jsoriano merged 3 commits intoelastic:mainfrom
jsoriano:add-threadintel-category
Jul 5, 2022
Merged

Add threat_intel package category#366
jsoriano merged 3 commits intoelastic:mainfrom
jsoriano:add-threadintel-category

Conversation

@jsoriano
Copy link
Copy Markdown
Member

@jsoriano jsoriano commented Jun 30, 2022

What does this PR do?

Add threat intel category.

Why is it important?

Closes #222

Related issues

@jsoriano jsoriano requested a review from a team as a code owner June 30, 2022 09:32
@jsoriano jsoriano self-assigned this Jun 30, 2022
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 30, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-30T09:55:37.769+0000

  • Duration: 11 min 52 sec

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@P1llus
Copy link
Copy Markdown
Member

P1llus commented Jun 30, 2022

@jsoriano this one says thread intel instead of threat intel, might be a typo?

@jsoriano
Copy link
Copy Markdown
Member Author

@jsoriano this one says thread intel instead of threat intel, might be a typo?

Yes 🤦

@jsoriano jsoriano changed the title Add thread_intel package category Add threat_intel package category Jun 30, 2022
@jlind23
Copy link
Copy Markdown
Collaborator

jlind23 commented Jun 30, 2022

@akshay-saraswat even if we merge this, can we have written down somewhere what are the criteria to add a new category? Otherwise I am scared we will end up with some low used ones.

@jlind23 jlind23 added the Team:Ecosystem Label for the Packages Ecosystem team label Jul 4, 2022
@jsoriano jsoriano merged commit e63d9c9 into elastic:main Jul 5, 2022
@jsoriano jsoriano deleted the add-threadintel-category branch July 5, 2022 11:43
@jamiehynds
Copy link
Copy Markdown

@jlind23 if the criteria for additional categories are published, could you please share There are several security categories that I'd really like to include for more granular categorisation and improved discoverability. We currently have 130+ integrations under the 'Security' category.

@jlind23
Copy link
Copy Markdown
Collaborator

jlind23 commented Jul 18, 2022

@jamiehynds nothing was wrote down so far. I'll bring that up again with @mukeshelastic and @akshay-saraswat.

@jamiehynds
Copy link
Copy Markdown

Thanks @jlind23 - here's some of the security categories I had in mind but can certainly narrow it down: elastic/integrations#1328

@akshay-saraswat
Copy link
Copy Markdown

@jamiehynds let's discuss this. We want to introduce a process so that we don't overdo the categories. I'll reach out with a draft proposal for feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team:Ecosystem Label for the Packages Ecosystem team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Change Proposal] Adding threatintel category option

7 participants