Don't check type for imported required fields#347
Merged
jsoriano merged 3 commits intoelastic:mainfrom Jun 3, 2022
Merged
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
andrewkroh
previously approved these changes
May 31, 2022
mtojek
previously approved these changes
May 31, 2022
|
|
||
| foundFields[datastream][f.Name] = struct{}{} | ||
|
|
||
| // Don't check type for external fields. |
Contributor
There was a problem hiding this comment.
Maybe drop a link to the PR/issue here. Otherwise, it's scary...
Member
Author
There was a problem hiding this comment.
Made it less scary 🙂 Please take another look.
mtojek
approved these changes
Jun 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
External fields don't have a type in the definition. When checking for presence of fields, don't
check the type on these fields.
Why is it important?
Required fields cannot be imported otherwise, as validation fails for un-resolved fields.
Checklist
test/packagesthat prove my change is effective.versions/N/changelog.yml.Related issues