Merged
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
joshdover
previously approved these changes
May 23, 2022
Contributor
joshdover
left a comment
There was a problem hiding this comment.
LGTM, thanks for adding this. It would be nice if we could emit warnings when beta features are used in non-GA packages too so that developers aren't surprised right when they're hoping to make a package GA. Let's consider that nice-to-have though unless it's easy to implement now.
Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com>
Contributor
Author
|
I added a warning. It should appear in the console similarly to this: |
joshdover
previously approved these changes
May 23, 2022
jsoriano
previously approved these changes
May 23, 2022
| // Release type of the spec: beta, ga. | ||
| // Packages using beta features won't be able to go GA. | ||
| // Default release: ga | ||
| Release string `yaml:"release"` |
Member
There was a problem hiding this comment.
Should we check somewhere that we only use beta or ga here? Or even only beta?
Contributor
Author
There was a problem hiding this comment.
I added a condition to check for "beta" and "ga" and report an error whenever there is a different level used.
jsoriano
previously approved these changes
May 24, 2022
Comment on lines
+90
to
+95
| if s.Release != "" && s.Release != "beta" { | ||
| errs = append(errs, errors.Errorf("unsupport release level, supported values: beta, ga")) | ||
| } else if s.Release == "beta" && pkg.Version.Prerelease() == "" { | ||
| errs = append(errs, errors.Errorf("spec for [%s] defines beta features which can't be enabled for packages with a stable semantic version", pkg.Path(path))) | ||
| } else if s.Release == "beta" && pkg.Version.Prerelease() != "" { | ||
| log.Printf("Warning: package with non-stable semantic version and active beta features (enabled in [%s]) can't be released as stable version.q", pkg.Path(path)) |
Member
There was a problem hiding this comment.
Nit. Use a switch for valid values to simplify conditions?
Suggested change
| if s.Release != "" && s.Release != "beta" { | |
| errs = append(errs, errors.Errorf("unsupport release level, supported values: beta, ga")) | |
| } else if s.Release == "beta" && pkg.Version.Prerelease() == "" { | |
| errs = append(errs, errors.Errorf("spec for [%s] defines beta features which can't be enabled for packages with a stable semantic version", pkg.Path(path))) | |
| } else if s.Release == "beta" && pkg.Version.Prerelease() != "" { | |
| log.Printf("Warning: package with non-stable semantic version and active beta features (enabled in [%s]) can't be released as stable version.q", pkg.Path(path)) | |
| switch s.Release { | |
| case "", "ga": | |
| case "beta": | |
| if pkg.Version.Prerelease() == "" { | |
| errs = append(errs, errors.Errorf("spec for [%s] defines beta features which can't be enabled for packages with a stable semantic version", pkg.Path(path))) | |
| } else { | |
| log.Printf("Warning: package with non-stable semantic version and active beta features (enabled in [%s]) can't be released as stable version.q", pkg.Path(path)) | |
| } | |
| default: | |
| errs = append(errs, errors.Errorf("unsupport release level, supported values: beta, ga")) | |
| } |
jsoriano
approved these changes
May 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR defines
release: betaflag for folder specs. Requested by @joshdover in comment.Related: #328
It might be hard to test it without providing a fake spec, so I'd rather test it against #328.