Skip to content

Remove pipeline test config json#150

Merged
ycombinator merged 5 commits intoelastic:masterfrom
ycombinator:remove-pipeline-test-config-json
Mar 17, 2021
Merged

Remove pipeline test config json#150
ycombinator merged 5 commits intoelastic:masterfrom
ycombinator:remove-pipeline-test-config-json

Conversation

@ycombinator
Copy link
Copy Markdown
Contributor

@ycombinator ycombinator commented Mar 16, 2021 •
edited
Loading

What does this PR do?

This PR removes the deprecated JSON-formatted pipeline test configuration files.

Why is it important?

In #139, we deprecated JSON-formatted pipeline test configuration files. Stakeholders were immediately notified of that change, including the notification that the deprecated files would be removed in a couple of weeks. We're at that point in time now.

Checklist

Related issues

@ycombinator
Copy link
Copy Markdown
Contributor Author

ycombinator commented Mar 16, 2021

I expect CI to fail on this PR as it stands at the moment because I have deliberately not yet removed the test-*-config.json files from under test/packages/**/_dev/test/pipeline/. This will serve as a test for the spec changes in this PR.

Once this CI failure is confirmed, I will remove the test-*-config.json files from under test/packages/**/_dev/test/pipeline/, which should cause CI to go green again.

@ycombinator ycombinator marked this pull request as draft March 16, 2021 17:43
@ycombinator ycombinator mentioned this pull request Mar 16, 2021
Closed
7 tasks
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Mar 16, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #150 updated

  • Start Time: 2021-03-16T18:02:23.986+0000

  • Duration: 2 min 20 sec

  • Commit: 46f059a

Trends 🧪

Image of Build Times

@ycombinator
Copy link
Copy Markdown
Contributor Author

ycombinator commented Mar 16, 2021 •
edited
Loading

CI failed as expected 👍:

[2021-03-16T17:52:57.944Z] === RUN   TestValidateFile/good

[2021-03-16T17:52:57.944Z]     validator_test.go:58: 

[2021-03-16T17:52:57.944Z]         	Error Trace:	validator_test.go:58

[2021-03-16T17:52:57.944Z]         	Error:      	Received unexpected error:

[2021-03-16T17:52:57.944Z]         	            	found 1 validation error:

[2021-03-16T17:52:57.944Z]         	            	   1. item [test-access-event.json-config.json] is not allowed in folder [../../../../test/packages/good/data_stream/foo/_dev/test/pipeline]

[2021-03-16T17:52:57.944Z]         	Test:       	TestValidateFile/good

[2021-03-16T17:52:57.944Z] === RUN   TestValidateFile/missing_data_stream

[2021-03-16T17:52:57.944Z] --- FAIL: TestValidateFile (0.09s)

Proceeding with removing the offending file now...

@ycombinator ycombinator marked this pull request as ready for review March 16, 2021 18:07
@ycombinator ycombinator requested a review from mtojek March 16, 2021 18:07
@ycombinator ycombinator merged commit a8ace9b into elastic:master Mar 17, 2021
@ycombinator ycombinator deleted the remove-pipeline-test-config-json branch March 17, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mtojek mtojek mtojek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ycombinator @elasticmachine @mtojek