Allow to use otelcol inputs in integration packages#1091
Merged
jsoriano merged 6 commits intoelastic:mainfrom Feb 23, 2026
Merged
Allow to use otelcol inputs in integration packages#1091jsoriano merged 6 commits intoelastic:mainfrom
jsoriano merged 6 commits intoelastic:mainfrom
Conversation
code/go/internal/validator/semantic/validate_input_dynamic_signal_types.go
Outdated
Show resolved
Hide resolved
teresaromero
previously approved these changes
Feb 18, 2026
…nal_types.go Co-authored-by: Tere <romero.teresa@protonmail.com>
teresaromero
previously approved these changes
Feb 18, 2026
mrodm
previously approved these changes
Feb 18, 2026
mrodm
previously approved these changes
Feb 19, 2026
teresaromero
previously approved these changes
Feb 19, 2026
mrodm
reviewed
Feb 20, 2026
Comment on lines
+674
to
+678
| - op: add | ||
| path: "/properties/streams/items/properties/input" | ||
| value: | ||
| not: | ||
| const: otelcol |
Contributor
There was a problem hiding this comment.
There this is patch, but this is not removed from the spec now in this file.
properties:
input:
type: string
examples:
- aws/metrics
- s3
- file
not:
const: otelcol
Member
Author
There was a problem hiding this comment.
Oops, I think I broke this in the merge.
Member
Author
There was a problem hiding this comment.
Or not, this was actually wrong before the merge. Fixed in e556170, with tests cases that would have catch this.
Good catch, thanks!
💚 Build Succeeded
History
cc @jsoriano |
teresaromero
approved these changes
Feb 23, 2026
mrodm
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1085
Allow to use
otelcolinputs anddynamic_signal_typesin integration packages starting on 3.6.0.otelcolwas supported for input packages since 3.5.0.Assisted by Copilot
Why is it important?
It is going to be possible to make OTel integrations depend on OTel input packages. After combining them they may include OTel configurations and use otelcol inputs.
Checklist
test/packagesthat prove my change is effective.spec/changelog.yml.Related issues