Add support for discovery based on datasets

mrodm · mrodm · commit 9965b7390b11 · 2025-07-08T12:23:24.000+02:00
diff --git a/code/go/pkg/validator/validator_test.go b/code/go/pkg/validator/validator_test.go
@@ -279,6 +279,7 @@ func TestValidateFile(t *testing.T) {
 				"field discovery.fields.0.name: Invalid type. Expected: string, given: integer",
 				"field discovery.fields.1: name is required",
 				"field discovery.fields.2.value: String length must be greater than or equal to 1",
+				"field discovery.datasets.0.name: Invalid type. Expected: string, given: integer",
 			},
 		},
 	}
diff --git a/compliance/testdata/packages/basic_content/manifest.yml b/compliance/testdata/packages/basic_content/manifest.yml
@@ -27,6 +27,9 @@ discovery:
       value: 12345
     - name: test.boolean
       value: true
+  datasets:
+    - name: nginx.stubstatus
+    - name: nginx.error
 screenshots:
   - src: /img/kibana-system.png
     title: kibana system
diff --git a/spec/content/manifest.spec.yml b/spec/content/manifest.spec.yml
@@ -13,6 +13,17 @@ spec:
       type: object
       additionalProperties: false
       properties:
+        datasets:
+          description: Description of the datasets this package can be used with.
+          type: array
+          items:
+            type: object
+            properties:
+              name:
+                description: Name of the dataset.
+                type: string
+            required:
+              - name
         fields:
           description: Description of the fields this package can be used with.
           type: array
diff --git a/test/packages/bad_discovery_fields/manifest.yml b/test/packages/bad_discovery_fields/manifest.yml
@@ -19,6 +19,8 @@ discovery:
     - value: nginx.access
     - name: event.dataset
       value: ""
+  datasets:
+    - name: 12345
 screenshots:
   - src: /img/sample-screenshot.png
     title: Sample screenshot
diff --git a/test/packages/good_content/manifest.yml b/test/packages/good_content/manifest.yml
@@ -26,6 +26,9 @@ discovery:
       value: 12345
     - name: test.boolean
       value: true
+  datasets:
+    - name: good_content.logs
+    - name: good_content.metrics
 screenshots:
   - src: /img/kibana-system.png
     title: kibana system

Original file line number	Diff line number	Diff line change
`@@ -279,6 +279,7 @@ func TestValidateFile(t *testing.T) {`
`279`	`279`	`"field discovery.fields.0.name: Invalid type. Expected: string, given: integer",`
`280`	`280`	`"field discovery.fields.1: name is required",`
`281`	`281`	`"field discovery.fields.2.value: String length must be greater than or equal to 1",`
	`282`	`+ "field discovery.datasets.0.name: Invalid type. Expected: string, given: integer",`
`282`	`283`	`},`
`283`	`284`	`},`
`284`	`285`	`}`