Remove deprecated corpora.generator.size in favour of `corpora.gene… (#639)

Andrea Spacca · web-flow · commit 0998b91dc748 · 2023-10-11T15:38:56.000+02:00
Remove deprecated `corpora.generator.size` in favour of `corpora.generator.total_events`
diff --git a/spec/changelog.yml b/spec/changelog.yml
@@ -7,6 +7,9 @@
   - description: Using non-GA versions of the spec in GA packages produces a filterable validation error instead of a warning.
     type: enhancement
     link: https://github.com/elastic/package-spec/pull/627
+  - description: Remove deprecated `corpora.generator.size` in favour of `corpora.generator.total_events`
+    type: breaking-change
+    link: https://github.com/elastic/package-spec/pull/639
   - description: Allow to define limits of nested and total number of fields.
     type: enhancement
     link: https://github.com/elastic/package-spec/pull/641
diff --git a/spec/integration/_dev/benchmark/system.scenario.spec.yml b/spec/integration/_dev/benchmark/system.scenario.spec.yml
@@ -65,17 +65,12 @@ spec:
           type: object
           additionalProperties: false
           required:
-            - size
+            - total_events
             - template
             - config
             - fields
           properties:
-            size:
-              description: A string describing the amount of data to generate.
-              type: string
-              example: 10MiB
-              deprecated: true # as for https://github.com/elastic/elastic-integration-corpus-generator-tool/pull/94
-            tot_events:
+            total_events:
               description: An integer describing the total number of events to generate.
               type: integer
               example: 1000
diff --git a/test/packages/integration_benchmarks/_dev/benchmark/rally/rally-benchmark.yml b/test/packages/integration_benchmarks/_dev/benchmark/rally/rally-benchmark.yml
@@ -2,7 +2,7 @@
 description: Benchmark 20MiB of data ingested
 data_stream.name: test
 warmup_time_period: 10s
-corpora.generator.size: 20MiB
+corpora.generator.total_events: 20000
 corpora.generator.template.raw: '{"@timestamp": "2016-12-07T10:04:37.000Z", "message": "a message"}'
 corpora.generator.config.path: ./20mb-track/config.yml
 corpora.generator.fields.path: ./20mb-track/fields.yml
diff --git a/test/packages/integration_benchmarks/_dev/benchmark/system/tcp-benchmark.yml b/test/packages/integration_benchmarks/_dev/benchmark/system/tcp-benchmark.yml
@@ -6,7 +6,7 @@ data_stream.dataset: test
 data_stream.vars.paths:
   - "{{SERVICE_LOGS_DIR}}/corpus-*"
 warmup_time_period: 10s
-corpora.generator.size: 20MiB
+corpora.generator.total_events: 20000
 corpora.generator.template.raw: a template
 corpora.generator.config.path: ./tcp-benchmark/config.yml
 corpora.generator.fields.path: ./tcp-benchmark/fields.yml
