Skip to content

Allow numbers in package names#614

Merged
adriansr merged 2 commits intoelastic:masterfrom
adriansr:numbers_in_packages_are_cool
Aug 3, 2020
Merged

Allow numbers in package names#614
adriansr merged 2 commits intoelastic:masterfrom
adriansr:numbers_in_packages_are_cool

Conversation

@adriansr
Copy link
Copy Markdown
Contributor

Fixes #613

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jul 30, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Started by user Adrian Serrano, Replayed #2]

  • Start Time: 2020-08-03T13:21:10.493+0000

  • Duration: 8 min 15 sec

Test stats 🧪

Test Results
Failed 0
Passed 161
Skipped 0
Total 161

@mtojek
Copy link
Copy Markdown
Contributor

mtojek commented Jul 30, 2020

FYI @ycombinator

Copy link
Copy Markdown
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you add a changelog entry?

@ruflin
Copy link
Copy Markdown
Collaborator

ruflin commented Jul 31, 2020

@adriansr As soon as this land, we might think about releasing a new version and adding it to the builds, see https://github.com/elastic/package-storage#update-package-registry-for-a-distribution We could also just get it into snapshot for to get the packages in and rollout a fully new version later. You can use the commit id for the container name.

@ruflin
Copy link
Copy Markdown
Collaborator

ruflin commented Aug 3, 2020

jenkins, test this

@adriansr Somehow CI seems to be hanging :-(

@adriansr adriansr merged commit 4bd9675 into elastic:master Aug 3, 2020
@adriansr adriansr deleted the numbers_in_packages_are_cool branch August 3, 2020 13:32
@adriansr adriansr mentioned this pull request Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Registry 404s on packages whose name contains a number

5 participants