Merged
Conversation
Collaborator
Author
|
This PR cannot be merged yet. |
29 tasks
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
Collaborator
Author
|
@ph Also assigning you to this one in case the snapshots are not updated in time. Hope this can be merged later today / tomorrow. |
mtojek
approved these changes
Jul 2, 2020
|
@ruflin ACK. |
ph
approved these changes
Jul 2, 2020
7c75e1e to
f3303f4
Compare
These legacy requirements were still in for compatiblity with the Kibana snapshots which were not up-to-date. As soon as these are, requirements can be removed.
f3303f4 to
9bbbfb0
Compare
Collaborator
Author
|
I tested this with the most recent snapshot builds and things seem to work now as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These legacy requirements were still in for compatiblity with the Kibana snapshots which were not up-to-date. As soon as these are, requirements can be removed.