Update package output structure#514
Merged
ruflin merged 8 commits intoelastic:masterfrom Jun 29, 2020
Merged
Conversation
Collaborator
Author
|
@jen-huang This is related to Phase 3: elastic/beats#19082 You should be able to use this branch to test changes in Kibana. |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
Collaborator
Author
|
Part of #517 |
29 tasks
Contributor
|
I'm hitting errors with |
a41fea9 to
cada7b0
Compare
Collaborator
Author
|
@jen-huang I rebased on master, now things should work as expected. |
15 tasks
This change contains several changes to the output generated for the package API endpoint: * dataset.id is renamed to dataset.name * datasources is renamed to config_templates. Currently only in the output, packages can follow later. * config_templates (aka datasources) do not pregenerate the content anymore to simply config building in Kibana * template_content is removed Further change is done to use `Dataset(s)` instead of `DataSet(s)` in the code for consistency.
3e88577 to
9bf9866
Compare
mtojek
approved these changes
Jun 29, 2020
Contributor
mtojek
left a comment
There was a problem hiding this comment.
Approved, but please make sure if the import-beats is not impacted with this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change contains several changes to the output generated for the package API endpoint:
Further change is done to use
Dataset(s)instead ofDataSet(s)in the code for consistency.