Merged
Conversation
ruflin
commented
May 11, 2020
|
|
||
| dataset: {{dataset}} | ||
|
|
||
| {{custom}} |
Collaborator
Author
There was a problem hiding this comment.
@nchaulet I tried to have a fully custom part in this config here. When I try to fill it in with foo: bar in the UI I get the following error:
can not read an implicit mapping pair; a colon is missed at line 7, column 13: "##custom##" ^
If would assume it replaced {{custom}} by foo: bar so it should be valid?
Member
There was a problem hiding this comment.
This a good scenario that we did not cover, I did the compilation of yaml to be able to support values like custom: {{custom}}
Thinking of the solution we have:
- We can probably add a new concept in the registry variables, to flag a variable that should be spread to the agent yaml.
- we can try to detect in the template that custom is a root level yaml value and do another special treatment, I have a POC here [Ingest] Support root level yaml variables in agent stream template kibana#66120
Collaborator
Author
There was a problem hiding this comment.
++ on option 2 as I would prefer to have as few "types" as possible on the package level.
ph
approved these changes
May 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.