Skip to content

feat: slack/notify-result#28

Merged
v1v merged 15 commits intomainfrom
feature/notify-build
Jun 4, 2024
Merged

feat: slack/notify-result#28
v1v merged 15 commits intomainfrom
feature/notify-build

Conversation

@v1v
Copy link
Copy Markdown
Member

@v1v v1v commented Jun 4, 2024

@v1v v1v self-assigned this Jun 4, 2024
@v1v v1v added the changelog:feature When you add a new feature label Jun 4, 2024
@v1v v1v marked this pull request as ready for review June 4, 2024 13:42
@@ -0,0 +1,29 @@
name: test-slack-build-result
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe notify-result rather than build-result

@v1v v1v changed the title feat: slack/build-result feat: slack/notify-result Jun 4, 2024
@v1v v1v enabled auto-merge (squash) June 4, 2024 13:44
@v1v v1v requested a review from a team June 4, 2024 13:45
@v1v v1v marked this pull request as draft June 4, 2024 13:47
auto-merge was automatically disabled June 4, 2024 13:47

Pull request was converted to draft

v1v added 2 commits June 4, 2024 15:52
@v1v v1v marked this pull request as ready for review June 4, 2024 14:07
v1v and others added 2 commits June 4, 2024 16:09
Co-authored-by: Jan Calanog <jan.calanog@elastic.co>
@reakaleek
Copy link
Copy Markdown
Member

Will the ref show main for the main branch?

@reakaleek
Copy link
Copy Markdown
Member

reakaleek commented Jun 4, 2024

IMO, the explicit status text would be beneficial for color-blind people, especially green/red color-blindness.

P.S.

it could also be some kind of icon.

@v1v
Copy link
Copy Markdown
Member Author

v1v commented Jun 4, 2024

IMO, the explicit status text would be beneficial for color-blind people, especially green/red color-blindness.

I see, how can we ensure the size of the message box smaller and also support the color being explicit?

@v1v
Copy link
Copy Markdown
Member Author

v1v commented Jun 4, 2024

Will the ref show main for the main branch?

Same behaviour as it's already done in the existing one:

@v1v
Copy link
Copy Markdown
Member Author

v1v commented Jun 4, 2024

IMO, the explicit status text would be beneficial for color-blind people, especially green/red color-blindness.

let's discuss this in a follow-up

@v1v v1v merged commit 2448610 into main Jun 4, 2024
@v1v v1v deleted the feature/notify-build branch June 4, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:feature When you add a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants