[8.16] Pin rubocop-ast development gem due to new dep on prism (backport #17407)#17427
Merged
[8.16] Pin rubocop-ast development gem due to new dep on prism (backport #17407)#17427
Conversation
The rubocop-ast gem just introduced a new dependency on prism. - https://rubygems.org/gems/rubocop-ast/versions/1.43.0 In our install default gem rake task we are seeing issues trying to build native extensions. I see that in upstream jruby they are seeing a similar problem (at least it is the same failure mode jruby/jruby#8415 This commit pins rubocop-ast to 1.42.0 which is the last version that did not have an explicit prism dependency. (cherry picked from commit 6de59f2)
We are pinning rubocop-ast to the last version that did not require prism. It is a development gem and should not change any behavior of LS.
|
💚 Build Succeeded
History
cc @donoghuc |
donoghuc
approved these changes
Mar 27, 2025
Member
donoghuc
left a comment
There was a problem hiding this comment.
Backport required Gemfile.lock udpate. Tests are green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]z
What does this PR do?
The rubocop-ast gem just introduced a new dependency on prism.
In our install default gem rake task we are seeing issues trying to build native extensions. I see that in upstream jruby they are seeing a similar problem (at least it is the same failure mode jruby/jruby#8415
This commit pins rubocop-ast to 1.42.0 which is the last version that did not have an explicit prism dependency.
Why is it important/What is the impact to the user?
NA
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)[ ] I have added tests that prove my fix is effective or that my feature worksRelated issues
Logs
Example failure with 1.43.0