[8.16] Surface failures from nested rake/shell tasks (backport #17310)#17316
[8.16] Surface failures from nested rake/shell tasks (backport #17310)#17316
Conversation
Previously when rake would shell out the output would be lost. This made debugging CI logs difficult. This commit updates the stack with improved message surfacing on error. (cherry picked from commit 0d931a5) # Conflicts: # rubyUtils.gradle
|
Cherry-pick of 0d931a5 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
This commit extends the gradle and rake tasks to pass through a list of files for rubocop to lint. This allows more specificity and fine grained control for linting when the consumer of the tasks only wishes to lint a select few files.
Without this depending on task load order `Shellwords` may not be available.
|
💚 Build Succeeded
History
cc @donoghuc |
| puts "Rake task error: #{e.class}: #{e.message}" | ||
| puts "Backtrace: #{e.backtrace.join("\\n")}" | ||
| raise e | ||
| end |
There was a problem hiding this comment.
Respect to 8.17 backport here is just a missed new line https://github.com/elastic/logstash/pull/17315/files#diff-7a2156b270dee259f243cf6371cdeb28e3bfdbc8c0e418cb37cfb4724144b305R172
There was a problem hiding this comment.
Good eye. This had some merge conflicts that needed some special care. I must have slipped up on a whitespace change.
|
This pull request has not been merged yet. Could you please review and merge it @donoghuc? 🙏 |
Release notes
[rn:skip]
What does this PR do?
Previously when rake would shell out the output would be lost. This made debugging CI logs difficult. This commit updates the stack with improved message surfacing on error.
Additionally this commit backports a change #16660 to allow linting specific files as it was originally missed and modifies the same method signature as we update in this backport.
'
Why is it important/What is the impact to the user?
N/A
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)[ ] I have added tests that prove my fix is effective or that my feature worksRelated issues
Logs
This is an automatic backport of pull request #17310 done by [Mergify](https://mergify.com).