Skip to content

[8.18] tests: ls2ls delay checking until events have been processed (backport #17167)#17250

Merged
mashhurs merged 1 commit into8.18from
mergify/bp/8.18/pr-17167
Mar 5, 2025
Merged

[8.18] tests: ls2ls delay checking until events have been processed (backport #17167)#17250
mashhurs merged 1 commit into8.18from
mergify/bp/8.18/pr-17167

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Mar 5, 2025

Release notes

[rn:skip]

What does this PR do?

Resolves flaky logstash-to-logstash integration test that was attempting to validate the processed events after ensuring that the right quantity had been received by adding a guard to ensure that the quantity of events had been processed

Why is it important/What is the impact to the user?

no user impact, speeds up CI by not needing to retry whole integration test jobs

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

This is an automatic backport of pull request #17167 done by [Mergify](https://mergify.com).

* tests: ls2ls delay checking until events have been processed

* Make sure upstream sends expected number of events before checking the expectation with downstream. Remove unnecessary or duplicated logics from the spec.

* Add exception handling in `wait_for_rest_api` to make wait for LS REST API retriable.

---------

Co-authored-by: Mashhur <mashhur.sattorov@elastic.co>
Co-authored-by: Mashhur <99575341+mashhurs@users.noreply.github.com>
(cherry picked from commit 73ffa24)
@mergify mergify bot added the backport label Mar 5, 2025
@mergify mergify bot assigned yaauie Mar 5, 2025
@elastic-sonarqube
Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

cc @yaauie

Copy link
Copy Markdown
Contributor

@mashhurs mashhurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm~

@mashhurs mashhurs merged commit ab11d4e into 8.18 Mar 5, 2025
7 checks passed
@mashhurs mashhurs deleted the mergify/bp/8.18/pr-17167 branch March 5, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants