Backport PR #17125 to 8.x: entrypoint: avoid polluting stdout#17136
Merged
Backport PR #17125 to 8.x: entrypoint: avoid polluting stdout#17136
Conversation
routes output from setup-related functions to stderr, so that stdout can include only the output of the actual program. (cherry picked from commit 91258c3)
|
💛 Build succeeded, but was flaky
Failed CI Steps |
donoghuc
approved these changes
Feb 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport PR #17125 to 8.x branch, original message:
Release notes
[rn:skip]
What does this PR do?
routes output from setup-related bits in the entrypoint scripts to stderr, so that stdout can include only the output of the actual program.
Why is it important/What is the impact to the user?
This change makes it possible to use the stdout of entrypoints like
bin/logstash-pluginwithout the setup-related pollution:For example, with #17124 addition of
--no-expand, and given anallowlistcontaining the names of plugins to keep,The above is not possible if the stdout of
bin/logstash-plugininvocation is littered with info about the JVM.Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)[ ] I have added tests that prove my fix is effective or that my feature worksAuthor's Checklist
How to test this PR locally
observe that the side-channel bits are on STDERR and can be redirected away
Logs
With patch, the info about which java is being used is on STDERR:
Without patch, the info about which java is being used is on STDOUT: