Backport PR #17114 to 8.x: spec: improve ls2ls spec#17116
Merged
Conversation
* spec: improve ls2ls spec - fixes upstream/downstream convention - upstream: the sending logstash (has an LS output) - downstream: the receiving logstash (has an LS input) - helper `run_logstash_instance` yields the `LogstashService` instance and handles the teardown. - pass the pipeline id and node name to the LS instances via command line flags to make logging easier to differentiate - use the generator input's sequence id to ensure that the _actual_ events generated are received by the downstream pipeline * start with port-offset 100 Co-authored-by: Mashhur <99575341+mashhurs@users.noreply.github.com> --------- Co-authored-by: Mashhur <99575341+mashhurs@users.noreply.github.com> (cherry picked from commit 9abad66)
|
💚 Build Succeeded
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport PR #17114 to 8.x branch, original message:
Release notes
[rn:skip]
What does this PR do?
run_logstash_instanceyields theLogstashServiceinstance and handles the teardown (prevents teardown getting skipped when an exception occurs before it).Why is it important/What is the impact to the user?
No user impact; better tests same basic coverage.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)