Backport PR #17082 to 8.x: qa: use clean expansion of LS tarball per fixture instance#17094
Merged
Backport PR #17082 to 8.x: qa: use clean expansion of LS tarball per fixture instance#17094
Conversation
* qa: use clean expansion of LS tarball per fixture instance Because QA tests can _modify_ the Logstash installation (e.g. those that invoke the plugin manager), it is important that the service wrapper begins with a clean expansion of the logstash tarball. * qa: enable safe reuse of ls_home in ls_to_ls tests (cherry picked from commit d20eb4d)
|
💚 Build Succeeded
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Backport PR #17082 to 8.x branch, original message:
Release notes
[rn: skip]
What does this PR do?
Ensures that Logstash integration tests are run against a clean expansion of the built tarball.
Why is it important/What is the impact to the user?
Because QA tests can modify the Logstash installation (e.g. those that invoke the plugin manager), it is important that the service wrapper begins with a clean expansion of the logstash tarball.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)[ ] I have added tests that prove my fix is effective or that my feature worksHow to test this PR locally
Run integration tests that invoke the Logstash service (or any of its sub-command features like the plugin manager):
Logs
see
expunging, indicating that the old was removedsee
expanding, indicating a fresh expansionsee
Using...as LS_HOME, indicating that the fresh expansion is being used