[Backport 8.16] Reimplement LogStash::String setting in Java (#16559) #16961
Merged
andsel merged 1 commit intoelastic:8.16from Jan 27, 2025
Merged
[Backport 8.16] Reimplement LogStash::String setting in Java (#16559) #16961andsel merged 1 commit intoelastic:8.16from
andsel merged 1 commit intoelastic:8.16from
Conversation
…16576) (elastic#16959) Non clean backport of elastic#16576 ---- Reimplements `LogStash::Setting::String` Ruby setting class into the `org.logstash.settings.SettingString` and exposes it through `java_import` as `LogStash::Setting::SettingString`. Updates the rspec tests in two ways: - logging mock is now converted to real Log4J appender that spy log line that are later verified - verifies `java.lang.IllegalArgumentException` instead of `ArgumentError` is thrown because the kind of exception thrown by Java code, during verification. * Fixed the rename of NullableString to SettingNullableString * Fixed runner test to use real spy logger from Java Settings instead of mock test double
|
7 tasks
💚 Build Succeeded
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Non clean backport of #16959 from 8.x to 8.16 (which is a non clean backport of #16576 to 8.x)
Changes respect to 8.x:
with_deprecated_aliasreceives also a parameter specifying the version where the setting is removed. In this case we removed the extra parameter to the methodlogstash/logstash-core/lib/logstash/environment.rb
Line 79 in a0378c0
logstash/logstash-core/spec/logstash/settings/setting_with_deprecated_alias_spec.rb
Line 157 in a0378c0
Reimplements
LogStash::Setting::StringRuby setting class into theorg.logstash.settings.SettingStringand exposes it throughjava_importasLogStash::Setting::SettingString. Updates the rspec tests in two ways:java.lang.IllegalArgumentExceptioninstead ofArgumentErroris thrown because the kind of exception thrown by Java code, during verification.Fixed the rename of NullableString to SettingNullableString
Fixed runner test to use real spy logger from Java Settings instead of mock test double
Release notes
What does this PR do?
Why is it important/What is the impact to the user?
Checklist
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs