[Backport 8.16] Reimplement LogStash::String setting in Java (#16576)#16948
Closed
andsel wants to merge 1 commit intoelastic:8.16from
Closed
[Backport 8.16] Reimplement LogStash::String setting in Java (#16576)#16948andsel wants to merge 1 commit intoelastic:8.16from
andsel wants to merge 1 commit intoelastic:8.16from
Conversation
Reimplements `LogStash::Setting::String` Ruby setting class into the `org.logstash.settings.SettingString` and exposes it through `java_import` as `LogStash::Setting::SettingString`. Updates the rspec tests in two ways: - logging mock is now converted to real Log4J appender that spy log line that are later verified - verifies `java.lang.IllegalArgumentException` instead of `ArgumentError` is thrown because the kind of exception thrown by Java code, during verification.
7 tasks
Member
Author
Note for reviewersThis is identical to #16576 , but targeted to 8.16 instead. Comparing against
|
💔 Build Failed
Failed CI Steps
History |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from commit 03b11e9
Reimplements
LogStash::Setting::StringRuby setting class into theorg.logstash.settings.SettingStringand exposes it throughjava_importasLogStash::Setting::SettingString. Updates the rspec tests in two ways:java.lang.IllegalArgumentExceptioninstead ofArgumentErroris thrown because the kind of exception thrown by Java code, during verification.Release notes
What does this PR do?
Why is it important/What is the impact to the user?
Checklist
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs