Backport 16907 to 8.x: Use --qualifier in release manager (#16907)#16913
Merged
dliappis merged 2 commits intoelastic:8.xfrom Jan 20, 2025
Merged
Backport 16907 to 8.x: Use --qualifier in release manager (#16907)#16913dliappis merged 2 commits intoelastic:8.xfrom
dliappis merged 2 commits intoelastic:8.xfrom
Conversation
This commit uses the new --qualifier parameter in the release manager for publishing dra artifacts. Additionally, simplifies the expected variables to rely on a simple `VERSION_QUALIFIER`. Snapshot builds are skipped when VERSION_QUALIFIER is set. Finally, for helping to test DRA PRs, we also allow passing the `DRA_BRANCH` option/env var to override BUILDKITE_BRANCH. Closes https://github.com/elastic/ingest-dev/issues/4856
Contributor
Author
|
For the sake of simplifying the review, the only file that needed conflict resolution was Here are the diffs between this backport PR for the modified files and the original PR #16907:
|
|
💚 Build Succeeded
cc @dliappis |
This was referenced Jan 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




(cherry picked from commit 9385cfa)
Automated backport had conflicts in
.buildkite/scripts/dra/build_docker.shwhere before main we also build ubi8.Release notes
[rn:skip]
What does this PR do?
This commit uses the new --qualifier parameter in the release manager for publishing dra artifacts. Additionally, simplifies the expected variables to rely on a simple
VERSION_QUALIFIER.Finally, we skip snapshot builds when VERSION_QUALIFIER is set.
Why is it important/What is the impact to the user?
Enables prerelease staging builds
How to test this PR
To test via this PR supply the following BK options to the staging pipeline:
which results in a successful build -> https://buildkite.com/elastic/logstash-dra-staging-pipeline/builds/177
Once it's merged, manual staging builds need to be triggered using only
VERSION_QUALIFIER; docs will be updated for https://docs.elastic.dev/ingest-dev-docs/logstash/dra#usage-of-version_qualifier_opt via a follow up PR.Also tested a snapshot build to ensure nothing's broken (this just requires
DRA_BRANCH="main"as params), it's successful -> https://buildkite.com/elastic/logstash-dra-snapshot-pipeline/builds/2052Related issues
Closes https://github.com/elastic/ingest-dev/issues/4856
Screenshots