Skip to content

Replace removed yaml module#16703

Merged
donoghuc merged 1 commit intoelastic:mainfrom
donoghuc:replace-yaml-module
Nov 20, 2024
Merged

Replace removed yaml module#16703
donoghuc merged 1 commit intoelastic:mainfrom
donoghuc:replace-yaml-module

Conversation

@donoghuc
Copy link
Copy Markdown
Member

Release notes

[rn:skip]

What does this PR do?

In #16586 the module include was removed. This causes failures in the script when the module is referenced. This commit re-enables the include for the yaml module.

- [ ] My code follows the style guidelines of this project
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
- [ ] I have added tests that prove my fix is effective or that my feature works

Example failed test: https://buildkite.com/elastic/logstash-exhaustive-tests-pipeline/builds/949#01934968-b66c-4455-ad70-1778cc13def3

In elastic#16586 the module include was
removed. This causes failures in the script when the module is referenced. This
commit re-enables the include for the yaml module.
@elastic-sonarqube
Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Copy Markdown
Contributor

@mashhurs mashhurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

@donoghuc
Copy link
Copy Markdown
Member Author

Looks like #16586 only landed in main. So I will merge this and not worry about any backports.

@donoghuc donoghuc merged commit 7b3d23b into elastic:main Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants