Backport PR #16495 to 8.15: Improve pipeline bootstrap error logs#16503
Merged
Backport PR #16495 to 8.15: Improve pipeline bootstrap error logs#16503
Conversation
This PR adds the cause errors details on the pipeline converge state error logs (cherry picked from commit e84fb45)
|
💛 Build succeeded, but was flaky
Failed CI Steps |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Backport PR #16495 to 8.15 branch, original message:
Release notes
Improved pipeline bootstrap error logs, it now includes the cause backtrace giving a hint where this issue occurred.
What does this PR do?
Any exceptions in the
CompiledPipelineconstructor during the input, filter and output setup will be re-thrown, with the message from the causing exception, but without the original stack trace. Sometimes, only the message isn't enough to identity form where the error is coming from, and adding the cause stacktrace to the logs would be useful for troubleshooting purposes.Another option would be replacing the
CompiledPipelinere-thrown exception stack trace, which is not recommended unless it's strictly necessary.This PR adds the
:causeerrors details on the pipeline converge state error logs, which should shed light on those cases where the message isn't clear or does not describe the error source.Why is it important/What is the impact to the user?
This PR gives users better visibility/understanding on pipeline's bootstrap errors.
Checklist
How to test this PR locally
Try to start a failing/invalid pipeline configuration and check the logs out.
Related issues