Skip to content

Backport PR #16485 to 8.15: Change SubstitutionVariables.replace_placeholders refine argument to optional#16487

Merged
mashhurs merged 1 commit into8.15from
backport_16485_8.15
Oct 1, 2024
Merged

Backport PR #16485 to 8.15: Change SubstitutionVariables.replace_placeholders refine argument to optional#16487
mashhurs merged 1 commit into8.15from
backport_16485_8.15

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot commented Oct 1, 2024

Backport PR #16485 to 8.15 branch, original message:


Release notes

[rn:skip]

What does this PR do?

The LogStash::Util::SubstitutionVariables#replace_placeholders was recently changed, and starting from Logstash 8.15.1 it requires a new argument (refine).
Considering plugins might be using this method internally (e.g: logstash-input-azure_event_hubs), we should make the new argument optional, so existing usages won't break due this change.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

How to test this PR locally

Related issues

…ine argument to optional (#16485)

(cherry picked from commit 8368c00)
Copy link
Copy Markdown
Contributor

@mashhurs mashhurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm~

@elastic-sonarqube
Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

@mashhurs mashhurs merged commit 1a8676d into 8.15 Oct 1, 2024
@mashhurs mashhurs deleted the backport_16485_8.15 branch October 1, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants