Split fips integration tests into two steps

donoghuc · donoghuc · commit 8b1ed894c333 · 2025-02-07T10:17:25.000-08:00
The integration tests suite takes about 40 minutes. This is far too slow for
reasonable feedback on a PR. This commit follows the pattern for the non-fips
integration tests whereby the tests are split into two sections that can run in
parallel across two steps. This should halve the feedback time.
diff --git a/.buildkite/pull_request_pipeline.yml b/.buildkite/pull_request_pipeline.yml
@@ -125,8 +125,8 @@ steps:
       manual:
         allowed: true
 
-  - label: ":lab_coat: Integration Tests - FIPS mode"
-    key: "integration-tests-fips"
+  - label: ":lab_coat: Integration Tests - FIPS mode / part 1"
+    key: "integration-tests-fips-part-1"
     agents:
       provider: gcp
       imageProject: elastic-images-prod
@@ -141,7 +141,43 @@ steps:
       set -euo pipefail
 
       docker build -t test-runner-image -f x-pack/distributions/internal/observabilitySRE/docker/Dockerfile .
-      docker run test-runner-image ./gradlew --info --stacktrace -PrunTestsInFIPSMode=true runIntegrationTests
+      docker run test-runner-image /bin/bash -c '
+        pushd qa/integration
+        glob1=(specs/*spec.rb)
+        glob2=(specs/**/*spec.rb)
+        all_specs=("${glob1[@]}" "${glob2[@]}")
+        # This is how we get the first half (double ::)
+        specs=${all_specs[@]::$((${#all_specs[@]} / 2))}
+        popd
+        ./gradlew --info --stacktrace -PrunTestsInFIPSMode=true runIntegrationTests -PrubyIntegrationSpecs="$specs"
+      '
+
+  - label: ":lab_coat: Integration Tests - FIPS mode / part 2"
+    key: "integration-tests-fips-part-2"
+    agents:
+      provider: gcp
+      imageProject: elastic-images-prod
+      image: family/platform-ingest-logstash-ubuntu-2204
+      machineType: "n2-standard-4"
+      diskSizeGb: 64
+    retry:
+      automatic:
+      # dont retry on failure while they are expected
+        - limit: 0
+    command: |
+      set -euo pipefail
+
+      docker build -t test-runner-image -f x-pack/distributions/internal/observabilitySRE/docker/Dockerfile .
+      docker run test-runner-image /bin/bash -c '
+        pushd qa/integration
+        glob1=(specs/*spec.rb)
+        glob2=(specs/**/*spec.rb)
+        all_specs=("${glob1[@]}" "${glob2[@]}")
+        # This is how we get the second half (single :)
+        specs=${all_specs[@]:$((${#all_specs[@]} / 2))}
+        popd
+        ./gradlew --info --stacktrace -PrunTestsInFIPSMode=true runIntegrationTests -PrubyIntegrationSpecs="$specs"
+      '
 
   - label: ":lab_coat: Integration Tests / part 1"
     key: "integration-tests-part-1"
