Pull back YAML approach since it fails on multidepth and introduce refining option.

mashhurs · mashhurs · commit 4a4fe9a44805 · 2024-07-31T13:23:23.000-07:00
diff --git a/logstash-core/lib/logstash/util/substitution_variables.rb b/logstash-core/lib/logstash/util/substitution_variables.rb
@@ -76,10 +76,12 @@ def replace_placeholders(value)
         raise LogStash::ConfigurationError, "Cannot evaluate `#{placeholder}`. Replacement variable `#{name}` is not defined in a Logstash secret store " +
             "or as an Environment entry and there is no default value given."
       end
-      # if ENV may carry array string, remove literal brackets and make array
-      # use YAML for backward compatibility to cover the cases with escaped chars (ex "[\"*\"]" => ["*"])
-      # YAML.load('*') fails but it is a valid use case
-      return replacement.is_a?(String) && replacement != '*' ? YAML.load(replacement) : replacement.to_s
+      # ENV may carry single quote or escaped double quote or single/double quoted entries in array string
+      if replacement.is_a?(String)
+        refined = replacement.gsub(/[\\"\\']/, '')
+        return refined.start_with?('[') && refined.end_with?(']') ? refined[1..-2].split(',').map(&:strip) : refined
+      end
+      replacement.to_s
     end
   end # def replace_placeholders
 
