Skip to content

Commit 37b8713

Browse files
committed
[test] fized integration tests that verifies loggers level to include the deprecation logger of DeprecatedAlias setting
1 parent 08da681 commit 37b8713

1 file changed

Lines changed: 12 additions & 4 deletions

File tree

qa/integration/specs/monitoring_api_spec.rb

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -389,14 +389,14 @@
389389
end
390390

391391
#default
392-
logging_get_assert logstash_service, "INFO", "TRACE",
392+
logging_get_assert logstash_service, ["WARN", "INFO"], "TRACE",
393393
skip: 'logstash.licensechecker.licensereader' #custom (ERROR) level to start with
394394

395395
#root logger - does not apply to logger.slowlog
396396
logging_put_assert logstash_service.monitoring_api.logging_put({"logger." => "WARN"})
397397
logging_get_assert logstash_service, "WARN", "TRACE"
398398
logging_put_assert logstash_service.monitoring_api.logging_put({"logger." => "INFO"})
399-
logging_get_assert logstash_service, "INFO", "TRACE"
399+
logging_get_assert logstash_service, ["WARN", "INFO"], "TRACE"
400400

401401
#package logger
402402
logging_put_assert logstash_service.monitoring_api.logging_put({"logger.logstash.agent" => "DEBUG"})
@@ -422,7 +422,7 @@
422422

423423
# all log levels should be reset to original values
424424
logging_put_assert logstash_service.monitoring_api.logging_reset
425-
logging_get_assert logstash_service, "INFO", "TRACE"
425+
logging_get_assert logstash_service, ["WARN", "INFO"], "TRACE"
426426
end
427427

428428

@@ -433,7 +433,15 @@ def logging_get_assert(logstash_service, logstash_level, slowlog_level, skip: ''
433433
result["loggers"].each do |k, v|
434434
next if !k.empty? && k.eql?(skip)
435435
if k.start_with? "logstash", "org.logstash" #logstash is the ruby namespace, and org.logstash for java
436-
expect(v).to eq(logstash_level), "logstash logger '#{k}' has logging level: #{v} expected: #{logstash_level}"
436+
if logstash_level.is_a?(Array)
437+
if logstash_level.size == 1
438+
expect(v).to eq(logstash_level[0]), "logstash logger '#{k}' has logging level: #{v} expected: #{logstash_level[0]}"
439+
else
440+
expect(logstash_level).to include(v), "logstash logger '#{k}' has logging level: #{v} expected to be one of: #{logstash_level}"
441+
end
442+
else
443+
expect(v).to eq(logstash_level), "logstash logger '#{k}' has logging level: #{v} expected: #{logstash_level}"
444+
end
437445
elsif k.start_with? "slowlog"
438446
expect(v).to eq(slowlog_level), "slowlog logger '#{k}' has logging level: #{v} expected: #{slowlog_level}"
439447
end

0 commit comments

Comments
 (0)