This repository was archived by the owner on Sep 22, 2022. It is now read-only.
Merged
Conversation
spalger
reviewed
Aug 8, 2017
lib/featureDetection.js
Outdated
|
|
||
| function getPathConfigFlag(stdout) { | ||
| if (stdout.indexOf(' --path.conf ') > -1) { | ||
| if (stdout.indexOf('-Dproperty=value') > -1) { |
Contributor
There was a problem hiding this comment.
Why not check for --property=value, since that's actually how we are passing the conf, not using -Dpath.conf
Contributor
Author
There was a problem hiding this comment.
oh geez, that's what I wanted. I was scanning the help text for --path.conf and ended up choosing the first difference I saw. Thanks.
Contributor
|
One question, but LGTM whenever you're ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
6.0
5.5
2.4