Add Icon, Link, Button, TextInput, CheckBox, Table, ControlledTable, ToolBar, and ToolBarFooter components.#28
Add Icon, Link, Button, TextInput, CheckBox, Table, ControlledTable, ToolBar, and ToolBarFooter components.#28cjcenizal wants to merge 18 commits intoelastic:masterfrom
Conversation
|
initial feedback (sorry for doing that, but I'll be focusing on the "negatives" for now... doesn't mean there are no "positive" feedback as well):
I agree that it's worth exploring 1px borders... the one thing I'd be careful here is that the header won't all of a sudden be too much "in your face", so we might need to subtle the header background to accommodate such change
Ties to the previous point... we'll need to try different options here and see what feels best
I think this can be solved in different ways... I like what we have today, but one thing I'd like to explore is a different shape to the label... shape is "sticky" in your mind... |
|
agree with @uboness comments. also please use color 5A5A5A for icons in buttons (as agreed in design reviews). |
|
example for a tag shape: |
|
@uboness love the second example with the tag pointing on the left side. feels like a real tag to me :) |
|
@cjcenizal for links could you try this for us: Quick and dirty link tests: http://codepen.io/altziebler/pen/dOKgJZ |
639b1fa to
456fe7a
Compare
|
@uboness @alt74 Thanks for the great feedback! I'm glad you're coming around on the tag design Jurgen. 😄 Those are great finds, Uri. I'm also a fan. In our next meeting let's talk some more about buttons, links, and inputs. I'd especially like to talk about the concept of affordance in relation to buttons, and accessibility in relation to inputs and links. Here's a summary of my thoughts (I'd like to dive in deeper in our meeting): ButtonsIn case anybody isn't already familiar with the concept of affordance, it's the idea that a thing should communicate how it's used by its appearance (shape, color, behavior etc). So, a button should communicate that it's pressable, somehow. There's a spectrum of affordance along which a button can lie -- from very weak (no affordance) to very strong (unmistakable affordance). I created this pen to demonstrate this spectrum. Our (awesome) aesthetic is flat but that doesn't take into account the importance of usability and it doesn't leverage our ability to design the user's interaction with the button. I want to preserve our flat aesthetic but also offer a stronger affordance to our users, which is why I think strengthening the affordance only in hover and active states is a good compromise. Thoughts? LinksThe current design for links is almost indistinguishable from regular text and it's entirely indistinguishable for colorblind users. Take a look at this pen for comparison. I think we have 2 requirements: 1) we need to make links stand out more from regular text and 2) we need the hover state to stand out from the regular state. What do you both think of this? Jurgen, if this makes sense to you, do you think you could brainstorm on some more link styles to meet these requirements? InputsUri, what about the focus state did you not like? That it existed at all? Or that it was dotted? We definitely need to indicate focus state in some manner; otherwise tabbing through inputs won't be possible. Jurgen, would you mind exploring some options? |
|
@cjcenizal for selected input please try color 6EADC1 (no dotted lines please - very noisy). |
|
Link exploration updated with 4 options: breaking some conventions here with idea 4 but I like it :) |
|
I should probably stay out of this, but I want to mention two things:
|
|
@spalger Thanks for chiming in and for the great reference! |
|
button test: http://codepen.io/altziebler/pen/mOGQao |
|
Nice work @alt74! Looks great. |
b981405 to
0e9899b
Compare
0e9899b to
c03da35
Compare
|
@cjcenizal Given that the ui framework is now in the Kibana repo, is your plan just to copy this change to over there? |
|
@epixa Yes |
|
Replacing this PR with elastic/kibana#9462 |


CC @uboness @alt74
Preview available at https://elastic.github.io/kibana-ui-framework/#/
New components
Outstanding components
Changes from design
Suggested explorations
Table lines and ToolBar size
Tags
Here are some examples of tags on other sites:
GMail
Trello
Pinterest
GitHub
I see some commonalities across these:
We could explore a number of directions for making our tags more distinct: