Skip to content

[7.x] Unifying converting listing pages to new layout (#98651)#99557

Merged
kibanamachine merged 2 commits intoelastic:7.xfrom
kibanamachine:backport/7.x/pr-98651
May 7, 2021
Merged

[7.x] Unifying converting listing pages to new layout (#98651)#99557
kibanamachine merged 2 commits intoelastic:7.xfrom
kibanamachine:backport/7.x/pr-98651

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

@kibanamachine kibanamachine commented May 6, 2021

Backports the following commits to 7.x:

@cchaos @kibanamachine
Unifying converting listing pages to new layout (elastic#98651)
2296964 
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: cchaos <caroline.horn@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label May 6, 2021
@kibanamachine kibanamachine enabled auto-merge (squash) May 6, 2021 22:34
@kibanamachine kibanamachine mentioned this pull request May 6, 2021
Merged
7 tasks
@myasonik
Copy link
Copy Markdown
Contributor

myasonik commented May 7, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor Author

kibanamachine commented May 7, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
kibanaReact 336 338 +2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
kibanaReact 207 208 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 138.8KB 138.7KB -142.0B
graph 1.1MB 1.1MB -134.0B
kibanaReact 312.0KB 312.0KB +30.0B
maps 2.7MB 2.7MB +122.0B
visualize 91.8KB 91.8KB -4.0B
total -128.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kibanaReact 117.6KB 119.9KB +2.3KB
Unknown metric groups

API count

id before after diff
kibanaReact 232 234 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @myasonik

@kibanamachine kibanamachine merged commit 092995d into elastic:7.x May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@myasonik myasonik

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kibanamachine @myasonik