Skip to content

[7.x] [Maps] add attribution to layer editor (#98328)#99073

Merged
nreese merged 1 commit intoelastic:7.xfrom
nreese:backport/7.x/pr-98328
May 3, 2021
Merged

[7.x] [Maps] add attribution to layer editor (#98328)#99073
nreese merged 1 commit intoelastic:7.xfrom
nreese:backport/7.x/pr-98328

Conversation

@nreese
Copy link
Copy Markdown
Contributor

@nreese nreese commented May 3, 2021

Backports the following commits to 7.x:

* [Maps] add attribution to layer editor

* update sources to getAttributionProvider

* remove attribution UI from EMS_XYZ source

* remove attribution UI from WMS source editor

* clean up

* tslint

* AttributionFormRow jest test

* add migration

* tslint

* i18n fixes

* attribution

* [Maps] Improving design and a11y for attribution layer settings (#38)

* Design and a11y improvements

* Buttons aria labels

* Addressing PR review

* tslint and i18n fixes

* update jest snapshots

* remove placeholder for url

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elizabet Oliveira <elizabet.oliveira@elastic.co>
@nreese nreese added the backport This PR is a backport of another PR label May 3, 2021
@nreese nreese enabled auto-merge (squash) May 3, 2021 16:43
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
maps 772 774 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.7MB 2.7MB +5.8KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit 7d3e2c3 into elastic:7.x May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants