[SecuritySolution] Fix legend content for events histogram by angorayc · Pull Request #97812 · elastic/kibana

angorayc · 2021-04-21T13:02:28Z

Summary

#89205
Steps to verify:

Go to network / Flows
Hover on any ip in Source IPs or Destination IPs table and select show top source.ip or show top destination.ip

exceptions:
If query success, it should display ips correctly in the legend.
If query failed, it should close the histogram panel and show an error toast.

Checklist

Unit or functional tests were updated or added to match the most common scenarios

elasticmachine · 2021-04-21T13:03:19Z

Pinging @elastic/security-solution (Team: SecuritySolution)

elasticmachine · 2021-04-21T13:03:19Z

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

angorayc · 2021-04-21T13:05:04Z

Sometimes the query failed with error array_index_out_of_bounds_exception - elastic/elasticsearch#72040

GET _search
{
    "aggregations": {
      "eventActionGroup": {
        "terms": {
          "field": "destination.ip",
          "missing": "0.0.0.0",
          "order": {
            "_count": "desc"
          },
          "size": 10
        },
        "aggs": {
          "events": {
            "date_histogram": {
              "field": "@timestamp",
              "fixed_interval": "2699999ms",
              "min_doc_count": 0,
              "extended_bounds": {
                "min": 1618959600000,
                "max": 1619045999999
              }
            }
          }
        }
      }
    },
    "query": {
      "bool": {
        "filter": [
          {
            "bool": {
              "must": [],
              "filter": [
                {
                  "match_all": {}
                }
              ],
              "should": [],
              "must_not": []
            }
          },
          {
            "exists": {
              "field": "destination.ip"
            }
          },
          {
            "range": {
              "@timestamp": {
                "gte": "2021-04-20T23:00:00.000Z",
                "lte": "2021-04-21T22:59:59.999Z",
                "format": "strict_date_optional_time"
              }
            }
          }
        ]
      }
    },
    "size": 0
  }

Response:

{
  "error" : {
    "root_cause" : [
      {
        "type" : "array_index_out_of_bounds_exception",
        "reason" : "Index 16 out of bounds for length 16"
      }
    ],
    "type" : "array_index_out_of_bounds_exception",
    "reason" : "Index 16 out of bounds for length 16"
  },
  "status" : 500
}

kibanamachine · 2021-05-03T12:25:28Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 6c363bd
Storybooks Preview
Pipeline Steps (look for red circles / failed steps)
Interpreting CI Failures

Failed CI Steps

Test Failures

Kibana Pipeline / jest / Jest Tests.x-pack/plugins/security_solution/server/search_strategy/security_solution/factory/matrix_histogram.Events matrixHistogram search strategy parse should parse data correctly

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

Error: expect(received).toMatchObject(expected)

- Expected  - 2
+ Received  + 9

@@ -54,12 +54,19 @@
                \"should\": [],
                \"must_not\": []
              }
            },
            {
-             \"exists\": {
-               \"field\": \"event.action\"
+             \"bool\": {
+               \"must\": [],
+               \"filter\": [
+                 {
+                   \"match_all\": {}
+                 }
+               ],
+               \"should\": [],
+               \"must_not\": []
              }
            },
            {
              \"range\": {
                \"@timestamp\": {
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/security_solution/server/search_strategy/security_solution/factory/matrix_histogram/index.test.ts:176:22)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)

Kibana Pipeline / jest / Jest Tests.x-pack/plugins/security_solution/public/common/components/matrix_histogram.utils getCustomChartData shoule format data correctly

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

Error: expect(received).toEqual(expected) // deep equality

- Expected  - 0
+ Received  + 2

@@ -1,7 +1,8 @@
  Array [
    Object {
+     "color": "#1EA593",
      "key": "g1",
      "value": Array [
        Object {
          "g": "g1",
          "x": 1,
@@ -18,10 +19,11 @@
          "y": 6,
        },
      ],
    },
    Object {
+     "color": "#2B70F7",
      "key": "g2",
      "value": Array [
        Object {
          "g": "g2",
          "x": 1,
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/security_solution/public/common/components/matrix_histogram/utils.test.ts:120:22)
    at Promise.then.completed (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/utils.js:276:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/utils.js:216:10)
    at _callCircusTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:212:40)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at _runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:149:3)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:63:9)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:57:9)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:57:9)
    at run (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:176:21)
    at jestAdapter (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:109:19)
    at runTestInternal (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:380:16)
    at runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:472:34)
    at Object.worker (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/testWorker.js:133:12)

Kibana Pipeline / jest / Jest Tests.x-pack/plugins/security_solution/public/overview/components/alerts_by_category.Alerts by category before loading data it renders the expected title

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

TypeError: data is not iterable
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/security_solution/public/common/components/matrix_histogram/index.tsx:169:15
    at mountMemo (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:16833:19)
    at Object.useMemo (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:17152:16)
    at useMemo (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react/cjs/react.development.js:1643:21)
    at MatrixHistogramComponent (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/security_solution/public/common/components/matrix_histogram/index.tsx:166:24)
    at renderWithHooks (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:16260:18)
    at updateFunctionComponent (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:18347:20)
    at updateSimpleMemoComponent (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:18285:10)
    at updateMemoComponent (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:18188:14)
    at beginWork$1 (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:20248:16)
    at HTMLUnknownElement.callCallback (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:336:14)
    at HTMLUnknownElement.callTheUserObjectsOperation (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-environment-jsdom/node_modules/jsdom/lib/jsdom/living/generated/EventListener.js:26:30)
    at innerInvokeEventListeners (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-environment-jsdom/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:318:25)
    at invokeEventListeners (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-environment-jsdom/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:274:3)
    at HTMLUnknownElementImpl._dispatch (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-environment-jsdom/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:221:9)
    at HTMLUnknownElementImpl.dispatchEvent (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-environment-jsdom/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:94:17)
    at HTMLUnknownElement.dispatchEvent (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-environment-jsdom/node_modules/jsdom/lib/jsdom/living/generated/EventTarget.js:231:34)
    at Object.invokeGuardedCallbackDev (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:385:16)
    at invokeGuardedCallback (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:440:31)
    at beginWork$$1 (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:25780:7)
    at performUnitOfWork (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:24698:12)
    at workLoopSync (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:24671:22)
    at performSyncWorkOnRoot (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:24270:11)
    at scheduleUpdateOnFiber (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:23698:7)
    at updateContainer (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:27103:3)
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:27528:7
    at unbatchedUpdates (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:24433:12)
    at legacyRenderSubtreeIntoContainer (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:27527:5)
    at Object.render (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:27608:10)
    at fn (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/enzyme-adapter-react-16/src/ReactSixteenAdapter.js:488:26)
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/enzyme-adapter-react-16/src/ReactSixteenAdapter.js:405:37
    at batchedUpdates$1 (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:24386:12)
    at Object.act (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom-test-utils.development.js:1092:14)
    at wrapAct (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/enzyme-adapter-react-16/src/ReactSixteenAdapter.js:405:13)
    at Object.render (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/enzyme-adapter-react-16/src/ReactSixteenAdapter.js:474:16)
    at new ReactWrapper (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/enzyme/src/ReactWrapper.js:115:16)
    at mount (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/enzyme/src/mount.js:10:10)
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/security_solution/public/overview/components/alerts_by_category/index.test.tsx:54:17
    at Promise.then.completed (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/utils.js:276:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/utils.js:216:10)
    at _callCircusHook (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:175:40)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:45:5)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:57:9)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:57:9)
    at run (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:176:21)
    at jestAdapter (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:109:19)
    at runTestInternal (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:380:16)
    at runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:472:34)
    at Object.worker (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/testWorker.js:133:12)

and 16 more failures, only showing the first 3.

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	6.6MB	6.6MB	+1.1KB

History

💚 Build #122617 succeeded 6b1ee25
💔 Build #121718 failed 55a8163293105e2383be3fe810b2d7da83f12d24
💛 Build #121410 was flaky 5e59435ce59cfc119ea1a7a2cb53c85889646363
💔 Build #121385 failed febdb7bd43f9bdae68e2b549a7cbeed80d043501

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @angorayc

semd · 2021-05-06T13:13:57Z

Fixed in #99468 instead

angorayc requested a review from a team as a code owner April 21, 2021 13:02

angorayc self-assigned this Apr 21, 2021

angorayc added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v7.13.0 v8.0.0 labels Apr 21, 2021

angorayc mentioned this pull request Apr 21, 2021

[Security Solution] Top N hover action for IP shows error or garbled data #89205

Closed

angorayc changed the title ~~[SecuritySolution] make sure stackByField exists~~ [SecuritySolution] Fix legend content for events histogram Apr 21, 2021

angorayc mentioned this pull request Apr 21, 2021

Using IP in date histogram aggregate causes array_index_out_of_bounds_exception elastic/elasticsearch#72040

Closed

spalger added v7.14.0 and removed v7.13.0 labels Apr 21, 2021

angorayc added v7.12.2 v7.13.0 labels Apr 22, 2021

angorayc added 3 commits April 27, 2021 11:28

make sure stackByField exists

41395c9

fix types

fda7c37

fix unit test

6b1ee25

angorayc force-pushed the issue-89205 branch from 55a8163 to 6b1ee25 Compare April 27, 2021 10:30

angorayc added 2 commits May 3, 2021 11:20

skip extra request for non-ip queries

2ed3b66

Merge branch 'master' of github.com:elastic/kibana into issue-89205

6c363bd

angorayc assigned semd May 4, 2021

angorayc closed this May 6, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SecuritySolution] Fix legend content for events histogram#97812

[SecuritySolution] Fix legend content for events histogram#97812
angorayc wants to merge 5 commits intoelastic:masterfrom
angorayc:issue-89205

angorayc commented Apr 21, 2021

Uh oh!

elasticmachine commented Apr 21, 2021

Uh oh!

elasticmachine commented Apr 21, 2021

Uh oh!

angorayc commented Apr 21, 2021 •

edited

Loading

Uh oh!

kibanamachine commented May 3, 2021 •

edited

Loading

Standard Out

Stack Trace

Standard Out

Stack Trace

Standard Out

Stack Trace

Uh oh!

semd commented May 6, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

angorayc commented Apr 21, 2021

Summary

Checklist

Uh oh!

elasticmachine commented Apr 21, 2021

Uh oh!

elasticmachine commented Apr 21, 2021

Uh oh!

angorayc commented Apr 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kibanamachine commented May 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Build Failed

Failed CI Steps

Test Failures

Standard Out

Stack Trace

Standard Out

Stack Trace

Standard Out

Stack Trace

Metrics [docs]

Async chunks

History

Uh oh!

semd commented May 6, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

angorayc commented Apr 21, 2021 •

edited

Loading

kibanamachine commented May 3, 2021 •

edited

Loading