[5.x] Streamline adding a visualization to a dashboard (#9400)#9756
Merged
stacey-gammon merged 1 commit intoelastic:5.xfrom Jan 6, 2017
Merged
[5.x] Streamline adding a visualization to a dashboard (#9400)#9756stacey-gammon merged 1 commit intoelastic:5.xfrom
stacey-gammon merged 1 commit intoelastic:5.xfrom
Conversation
* Fix bug with param sticking around in the url causing multiple vis to add again and again Move the link into the saved object finder and get rid of the management link fix crash in tests lint fixes * rebase with master * code review comments make the function simpler and reduce the need to pass null everywhere * address comments and cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #9400
Move the link into the saved object finder
and get rid of the management link
fix crash in tests
lint fixes
rebase with master
code review comments
make the function simpler and reduce the need to pass null everywhere