Skip to content

Revert "[Security Solution] [Cases] Move create page components and dependencies to Cases"#94975

Merged
stephmilovic merged 1 commit intomasterfrom
revert-94444-cases_moving_create
Mar 19, 2021
Merged

Revert "[Security Solution] [Cases] Move create page components and dependencies to Cases"#94975
stephmilovic merged 1 commit intomasterfrom
revert-94444-cases_moving_create

Conversation

@stephmilovic
Copy link
Copy Markdown
Contributor

@stephmilovic stephmilovic commented Mar 18, 2021

Reverts #94444

@stephmilovic stephmilovic requested review from a team as code owners March 18, 2021 19:46
@stephmilovic stephmilovic added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v7.13.0 v8.0.0 labels Mar 18, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 18, 2021

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 18, 2021

Pinging @elastic/security-solution (Team: SecuritySolution)

mistic
mistic approved these changes Mar 18, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files under operations team code owners LGTM

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 18, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cases 184 - -184
securitySolution 2184 2203 +19
total -165

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 180.2KB - -180.2KB
securitySolution 7.2MB 7.2MB -1.3KB
total -181.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cases 80.4KB - -80.4KB
securitySolution 197.4KB 211.3KB +13.9KB
total -66.5KB
Unknown metric groups

async chunk count

id before after diff
cases 6 - -6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stephmilovic stephmilovic merged commit 5f4939b into master Mar 19, 2021
@spalger spalger deleted the revert-94444-cases_moving_create branch March 19, 2021 00:53
@cnasikas cnasikas mentioned this pull request Mar 22, 2021
Merged
2 tasks
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 23, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 23, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 94975 or prevent reminders by adding the backport:skip label.

@michaelolo24 michaelolo24 added backport:skip This PR does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XavierM XavierM XavierM approved these changes

@mistic mistic mistic approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v7.13.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@stephmilovic @elasticmachine @kibanamachine @XavierM @mistic @michaelolo24