[Core] create deprecations service#94845
Merged
Bamieh merged 37 commits intoelastic:masterfrom Mar 30, 2021
Merged
Conversation
8 tasks
Contributor
|
Pinging @elastic/kibana-core (Team:Core) |
azasypkin
approved these changes
Mar 22, 2021
Contributor
azasypkin
left a comment
There was a problem hiding this comment.
Code review only, Security and Spaces changes LGTM.
alisonelizabeth
approved these changes
Mar 22, 2021
Contributor
alisonelizabeth
left a comment
There was a problem hiding this comment.
This looks great @Bamieh! Thanks for working on it.
I read through the documentation and did a light code review. Overall LGTM. I left one comment in the code - let me know what you think.
This was referenced Apr 1, 2021
This was referenced Apr 15, 2021
Closed
Open
[Breaking change] Provide sensible defaults for
xpack.security.session.{lifespan|idleTimeout}
#81747
Closed
This was referenced May 19, 2021
Contributor
|
@elastic/kibana-core are we planning to remove the deprecated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecations Service
The deprecations service provides a way for the Kibana platform to communicate deprecated features and configs with its users.
These deprecations are only communicated if the deployment is using these features. Allowing for a user tailored experience for upgrading the stack version.
Registering deprecated features for you plugin:
Each plugin will be responsible for registering any deprecations during the
setuplifecycle by using the deprecations service:The
getDeprecationsfunction is invoked when the user requests to see the deprecations affecting their deployment. The function is passed a context object{ esClient, savedObjectsClient }.Example
Deprecated Configs
The core service automatically hooks deprecated configs with the deprecations service.
All the config deprecation functions (
unused,unusedFromRoot,rename,renameFromRoot) now accept an optional parameter to customize the deprecation details.Example
If Kibana has the config
ui_metric.debugin thekibana.ymlfile. The deprecations service will show the following config deprecation details:Plugin config registering custom deprecations
Custom config deprecation handling allows specifying the deprecation details via the
addDeprecation.Example:
Deprecations Client
Front the
publicside of the plugins,coreexposes a deprecations client which communicates with the kibana server and grabs the deprecations.The
startcontract exposes the following methods:Deprecations API
This API
GET /api/deprecations/provides the user with the list of deprecations and possible corrective actions required to resolve these entries. The context is scoped to the requesting user, hence a user with limited access might not be able to see all the deprecations affecting the deployment.Sample response
Note to reviewers
Please filter by code owners and check for changes. Since the
loggerwas swapped withaddDeprecationfor custom config deprecations you might just need to review those 1 line changes for your plugin.Related work for Upgrade assitant: https://github.com/elastic/elasticsearch-team-planning/issues/135