[App Search] Role mappings migration (full)#94390
Closed
scottybollinger wants to merge 21 commits intoelastic:masterfrom
Closed
[App Search] Role mappings migration (full)#94390scottybollinger wants to merge 21 commits intoelastic:masterfrom
scottybollinger wants to merge 21 commits intoelastic:masterfrom
Conversation
The original asRoleMapping was merely for a smoke test in the shared component. Refactored to work better in App Search component
ROLE_MAPPINGS_TITLE was moved to a shared constant in an earlier PR
The original asRoleMapping was merely for a smoke test in the shared component. Refactored to work better in App Search component
2 tasks
Co-authored-by: Jason Stoltzfus <jastoltz24@gmail.com>
Co-authored-by: Jason Stoltzfus <jastoltz24@gmail.com>
…r/yolo-as-role-mappings # Conflicts: # x-pack/plugins/enterprise_search/public/applications/app_search/components/role_mappings/role_mappings_logic.test.ts # x-pack/plugins/enterprise_search/public/applications/app_search/components/role_mappings/role_mappings_logic.ts
The ID is inferred from the param in the URL. This was fixed in the logic file but the server route was never updated
Refactoring the tests showed me that some parts of the state weren’t being reset.
I some how got the test coverage at 100% with my wrong way of doing tests before (scary). When I fixed it I noticed that noting I could do would trigger the fallback of just returning the `[ANY_AUTH_PROVIDER]` array. After talking with Constance, we could not come up with a way to trigger it either, given the conditions. She had suggested removing the first return statement but that caused an empty array being returned sometimes. Ultimately, I was able to get it working and covered with these changes.
The places where `role: 'superuser’` was deleted in the listeners was a side effect of using `setRoleMappingData` and not `mount`
…r/yolo-as-role-mappings # Conflicts: # x-pack/plugins/enterprise_search/public/applications/app_search/components/role_mappings/constants.ts
Contributor
💔 Build Failed
Failed CI Steps
Test FailuresKibana Pipeline / general / X-Pack Detection Engine API Integration Tests.x-pack/test/detection_engine_api_integration/security_and_spaces/tests/delete_signals_migrations·ts.detection engine api security and spaces enabled deleting signals migrations rejects the request if the user does not have sufficient privilegesStandard OutStack TraceKibana Pipeline / general / X-Pack Detection Engine API Integration Tests.x-pack/test/detection_engine_api_integration/security_and_spaces/tests/delete_signals_migrations·ts.detection engine api security and spaces enabled deleting signals migrations rejects the request if the user does not have sufficient privilegesStandard OutStack TraceMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the placeholder draft PR that holds the full feature for testing. This branch contains all the code for the child PRs and will be closed once those are merged, if we decide to break them up. Otherwise, follow along by commit.