Skip to content

[7.12] [Security Solution][Detections][7.12] Critical Threshold Rule Fixes (#92667)#93141

Merged
madirey merged 2 commits intoelastic:7.12from
madirey:backport/7.12/pr-92667
Mar 2, 2021
Merged

[7.12] [Security Solution][Detections][7.12] Critical Threshold Rule Fixes (#92667)#93141
madirey merged 2 commits intoelastic:7.12from
madirey:backport/7.12/pr-92667

Conversation

@madirey
Copy link
Copy Markdown
Contributor

@madirey madirey commented Mar 1, 2021

Backports the following commits to 7.12:

@madirey
[Security Solution][Detections][7.12] Critical Threshold Rule Fixes (e…
68fd37c 
…lastic#92667)

* Threshold cardinality validation

* Remove comments

* Fix legacy threshold signal dupe mitigation

* Add find_threshold_signals tests

* remove comment

* bug fixes

* Fix edit form value initialization for cardinality_value

* Fix test

* Type and test fixes

* Tests/types

* Reenable threshold cypress test

* Schema fixes

* Types and tests, normalize threshold field util

* Continue cleaning up types

* Some more pre-7.12 tests

* Limit cardinality_field to length 1 for now

* Cardinality to array

* Cardinality to array

* Tests/types

* cardinality can be null

* Handle empty threshold field in bulk_create_threshold_signals

* Remove cardinality_field, cardinality_value
@madirey madirey added the backport This PR is a backport of another PR label Mar 1, 2021
@madirey madirey enabled auto-merge (squash) March 1, 2021 22:11
@madirey
Copy link
Copy Markdown
Contributor Author

madirey commented Mar 2, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 2, 2021

💛 Build succeeded, but was flaky

Test Failures

Kibana Pipeline / general / "before all" hook for "should contain the right query".Timeline query tab Query tab "before all" hook for "should contain the right query"

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

AssertionError: Timed out retrying after 60000ms: Expected to find element: `[data-test-subj="title-554a4c30-7af9-11eb-9929-cbcd861a5e45"]`, but never found it.

Because this error occurred during a `before all` hook we are skipping the remaining tests in the current suite: `Timeline query tab`

Although you have test retries enabled, we do not retry tests when `before all` or `after all` hooks fail
    at Object.openTimelineById (http://localhost:6111/__cypress/tests?p=cypress/integration/timelines/query_tab.spec.ts:16059:15)
    at Context.eval (http://localhost:6111/__cypress/tests?p=cypress/integration/timelines/query_tab.spec.ts:15045:28)

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 7.7MB 7.7MB +1.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 245.8KB 246.6KB +766.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@madirey madirey merged commit f2123b3 into elastic:7.12 Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@madirey @kibanamachine